feat(otel): Add per-PR OTel conformance test suite - #630
Conversation
This comment has been minimized.
This comment has been minimized.
51bf2d8 to
609d7ce
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
609d7ce to
889e44f
Compare
This comment has been minimized.
This comment has been minimized.
889e44f to
3bed45e
Compare
This comment has been minimized.
This comment has been minimized.
727842b to
92b7102
Compare
This comment has been minimized.
This comment has been minimized.
Claude AI reviewThis PR adds a standalone One confirmed, CI-breaking issue: the reusable-workflow reference still contains the literal placeholder Minor (not blocking): Residual test risk: none of the new handlers are exercised by local/replay tests (by design); their behavior is only validated by the external orchestrator once the SHA is pinned, so regressions in the ported scenarios would surface only in the deployed conformance run. Reviewed commit |
92b7102 to
86d7487
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| # Build the handlers from this repo's checked-out module instead of the conformance repo's | ||
| # bundled examples/java. Path is relative to the conformance workspace where the SDK is | ||
| # checked out (.build/durable-sdk). | ||
| examples_dir: .build/durable-sdk/conformance-tests-otel |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
We are removing those in aws/aws-durable-execution-conformance-tests#95
This comment has been minimized.
This comment has been minimized.
Codex AI reviewNo actionable findings. Residual risk remains in the live SAM deployment and external OTel backend matrix, which were not executed under the read-only review constraints. Reviewed commit |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
aws/aws-durable-execution-conformance-tests#90
Description
Adds a per-PR OTel conformance suite for the Java SDK, matching the per-PR coverage the non-OTel
conformance-tests/module already has.conformance-tests-otel/module: handlers ported fromaws/aws-durable-execution-conformance-tests's Java OTel example project (otel-invocation, otel-execution, and otel-long-running in short mode), plustemplate.yamlandtemplate-long-running.yaml..github/workflows/otel-conformance-tests.yml: runs on PRs touchingsdk/**,otel-plugin/**, orconformance-tests-otel/**, across the X-Ray, Dash0, Datadog, and S3-collector backends.conformance-tests.yml/e2e-tests.ymlalready use, plus new Dash0/Datadog credentials for those two backends.Demo/Screenshots
N/A
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? N/A
Integration Tests
Have integration tests been written for these changes? N/A
Examples
Has a new example been added for the change? (if applicable) N/A